Re: [PATCH v1 3/4] powerpc/mm: remove linear mapping if __add_pages() fails in arch_add_memory()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Hildenbrand <david@xxxxxxxxxx>
Subject: Re: [PATCH v1 3/4] powerpc/mm: remove linear mapping if __add_pages() fails in arch_add_memory()
From: osalvador <osalvador@xxxxxxx>
Date: Wed, 4 Nov 2020 10:50:07 +0100
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Rashmica Gupta <rashmica.g@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxx>, Wei Yang <richard.weiyang@xxxxxxxxxxxxxxxxx>
In-reply-to: <20201029162718.29910-4-david@redhat.com>
References: <20201029162718.29910-1-david@redhat.com> <20201029162718.29910-4-david@redhat.com>

On Thu, Oct 29, 2020 at 05:27:17PM +0100, David Hildenbrand wrote:
> Let's revert what we did in case seomthing goes wrong and we return an
> error.

Dumb question, but should not we do this for other arches as well?


-- 
Oscar Salvador
SUSE L3

Follow-Ups:
- Re: [PATCH v1 3/4] powerpc/mm: remove linear mapping if __add_pages() fails in arch_add_memory()
  - From: Mike Rapoport

References:
- [PATCH v1 0/4] powernv/memtrace: don't abuse memory hot(un)plug infrastructure for memory allocations
  - From: David Hildenbrand
- [PATCH v1 3/4] powerpc/mm: remove linear mapping if __add_pages() fails in arch_add_memory()
  - From: David Hildenbrand

Prev by Date: Re: [PATCH v1 2/4] powerpc/mm: print warning in arch_remove_linear_mapping()
Next by Date: [PATCH] mm/gup_benchmark: GUP_BENCHMARK depends on DEBUG_FS
Previous by thread: [PATCH v1 3/4] powerpc/mm: remove linear mapping if __add_pages() fails in arch_add_memory()
Next by thread: Re: [PATCH v1 3/4] powerpc/mm: remove linear mapping if __add_pages() fails in arch_add_memory()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]