On Tue, Nov 3, 2020 at 6:53 AM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > On Tue, Nov 03, 2020 at 08:27:00AM +0100, Christoph Hellwig wrote: > > On Mon, Nov 02, 2020 at 06:42:56PM +0000, Matthew Wilcox (Oracle) wrote: > > > The recent split of generic_file_buffered_read() created some very > > > long function names which are hard to distinguish from each other. > > > Rename as follows: > > > > > > generic_file_buffered_read_readpage -> filemap_read_page > > > generic_file_buffered_read_pagenotuptodate -> filemap_update_page > > > generic_file_buffered_read_no_cached_page -> filemap_create_page > > > generic_file_buffered_read_get_pages -> filemap_get_pages > > > > Find with me, although I think filemap_find_get_pages would be a better > > name for filemap_get_pages. > > To me, 'find' means 'starting from this position, search forward in the > array for the next page', but we don't want to do that, we just want to > get a batch of pages starting _at_ this index. Arguably it'd be better > named filemap_get_or_create_batch(). filemap_get_or_crerate_batch() would be a better name, as to me, find entails "begin here and continue looking for the next instance" (in this case, an instance would be a page). Best regards, Amy Parker (they/them)
