On Tue, Nov 3, 2020 at 9:38 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> On Mon, Nov 02, 2020 at 01:31:51PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@xxxxxxxx>
> >
> > These are all handled correctly when calling the native
> > system call entry point, so remove the special cases.
>
> Ok, this is where you do it. I think this belongs into the main
> patches.
I had it there originally, I guess I should have left it there ;-)
When I changed it, I was considering to do the same for additional
syscalls that have very small differences now (timer_create,
rt_sigqueueinfo, rt_sigpending, recvmsg, sendmsg) and use
in_compat_syscall() there, but then I decided against that.
In the end, I did like the split, as I found the smaller three
patches that contain the real change easier to review, and
it turns the larger patch at the end into a more obvious
transformation.
Arnd
