Re: [PATCH v2 2/2] mm: prevent gup_fast from racing with COW during fork

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Ahmed S. Darwish" <a.darwish@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2 2/2] mm: prevent gup_fast from racing with COW during fork
From: Jason Gunthorpe <jgg@xxxxxxxxxx>
Date: Mon, 2 Nov 2020 20:25:32 -0400
Cc: Peter Xu <peterx@xxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Andrea Arcangeli <aarcange@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Hugh Dickins <hughd@xxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, John Hubbard <jhubbard@xxxxxxxxxx>, Kirill Shutemov <kirill@xxxxxxxxxxxxx>, Kirill Tkhai <ktkhai@xxxxxxxxxxxxx>, Leon Romanovsky <leonro@xxxxxxxxxx>, Linux-MM <linux-mm@xxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Sebastian Siewior <bigeasy@xxxxxxxxxxxxx>
In-reply-to: <20201103001712.GB52235@lx-t490>
References: <0-v2-dfe9ecdb6c74+2066-gup_fork_jgg@nvidia.com> <2-v2-dfe9ecdb6c74+2066-gup_fork_jgg@nvidia.com> <20201030225250.GB6357@xz-x1> <20201030235121.GQ2620339@nvidia.com> <20201103001712.GB52235@lx-t490>

On Tue, Nov 03, 2020 at 01:17:12AM +0100, Ahmed S. Darwish wrote:

> Please stick with the official exported API: raw_write_seqcount_begin().

How did you know this was 'offical exported API' ??

> Exactly. '*_seqcount_t_*' is a seqlock.h implementation detail, and it
> has _zero_ relevance to what is discussed in this thread actually.

Add some leading __'s to them?

Jason

Follow-Ups:
- Re: [PATCH v2 2/2] mm: prevent gup_fast from racing with COW during fork
  - From: Ahmed S. Darwish

References:
- [PATCH v2 0/2] Add a seqcount between gup_fast and copy_page_range()
  - From: Jason Gunthorpe
- [PATCH v2 2/2] mm: prevent gup_fast from racing with COW during fork
  - From: Jason Gunthorpe
- Re: [PATCH v2 2/2] mm: prevent gup_fast from racing with COW during fork
  - From: Peter Xu
- Re: [PATCH v2 2/2] mm: prevent gup_fast from racing with COW during fork
  - From: Jason Gunthorpe
- Re: [PATCH v2 2/2] mm: prevent gup_fast from racing with COW during fork
  - From: Ahmed S. Darwish

Prev by Date: Re: [PATCH for-rc v1] IB/hfi1: Move cached value of mm into handler
Next by Date: [PATCH 4/4] huegtlbfs: handle page fault/truncate races
Previous by thread: Re: [PATCH v2 2/2] mm: prevent gup_fast from racing with COW during fork
Next by thread: Re: [PATCH v2 2/2] mm: prevent gup_fast from racing with COW during fork
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]