On 11/1/20 9:38 AM, Matthew Wilcox wrote: > On Sun, Nov 01, 2020 at 12:31:05PM -0500, Arvind Sankar wrote: >> Commit >> b9de06783f01 ("compiler.h: fix barrier_data() on clang") >> moved the definition of barrier() into compiler.h. > > That's not a real commit ID. It only exists in linux-next and > will expire after a few weeks. > > The right way to fix a patch in Andrew's tree is to send an email > asking him to apply it as a -fix patch. As part of Andrew's submission > process, he folds all the -fix patches into the parent patch and it > shows up pristine in Linus' tree. > >> This causes build failures at least on alpha, because there are files >> that rely on barrier() being defined via the implicit include of >> compiler_types.h. > > That seems like a bug that should be fixed rather than reverting this > part of the patch? > maybe: ? https://lore.kernel.org/lkml/20201101030159.15858-1-rdunlap@xxxxxxxxxxxxx/ -- ~Randy