On Sat, Oct 31, 2020 at 09:59:56AM +0100, Christoph Hellwig wrote: > +static int filemap_new_page(struct kiocb *iocb, struct iov_iter *iter, > + struct page **page) I don't like this calling convention. It's too easy to get it wrong, as you demonstrated. I preferred the way Kent had it with returning an ERR_PTR.
