On Sat, Oct 31, 2020 at 09:59:51AM +0100, Christoph Hellwig wrote: > Hi Andrew, > > this series cleans up refactors our generic read from page cache helpers. > The recent usage of the gang lookups helped a fair amount compared to > the previous state, but left some of the old mess and actually introduced > some new rather odd calling conventions as well. > > Matthew: I think this should actually help with your THP work even if it > means another rebase. I was a bit surprised how quickly the gang lookups > went in as well. I think this is 90% the same direction I'm heading in. I'll chime in with a few suggestions on the individual patches.