Re: [PATCH v2] mm/msync: exit early when the flags is an MS_ASYNC and start < vm_start

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On 23 Oct 2020, at 14:12, Vlastimil Babka <vbabka@xxxxxxx> wrote:
> 
> On 10/20/20 10:56 PM, Nikita Ermakov wrote:
>> If an unmapped region was found and the flag is MS_ASYNC (without
>> MS_INVALIDATE) there is nothing to do and the result would be always
>> -ENOMEM, so return immediately.
>> Signed-off-by: Nikita Ermakov <sh1r4s3@xxxxxxxxxxxxxxx>
>> ---
>>  mm/msync.c | 2 ++
>>  1 file changed, 2 insertions(+)
>> diff --git a/mm/msync.c b/mm/msync.c
>> index 69c6d2029531..ed20c3621d4c 100644
>> --- a/mm/msync.c
>> +++ b/mm/msync.c
>> @@ -69,6 +69,8 @@ SYSCALL_DEFINE3(msync, unsigned long, start, size_t, len, int, flags)
>>  			goto out_unlock;
>>  		/* Here start < vma->vm_end. */
>>  		if (start < vma->vm_start) {
> 
> I hoped it would become a code comment.
> 

Ops, I'm sorry. I've implemented this suggestion in the v3.

>> +			if (flags == MS_ASYNC)
>> +				goto out_unlock;
>>  			start = vma->vm_start;
>>  			if (start >= end)
>>  				goto out_unlock;
>> base-commit: 6824a8a9b4861d7df7ee132a952bdf6f84a99cb8

--
Thanks,
Nikita
B8 00 4C CD 21






[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux