>> Is it overkill to avoid duplicating this switch logic in >> page_is_devmap_managed() by creating another call which can be used here? > > Perhaps. I can imagine a helper defined in include/linux/mm.h which > page_is_devmap_managed() could also call but that would impact a lot of > places that include mm.h. Since memremap.c already has to have intimate > knowledge of the pgmap->type, I think limiting the change to just what > is needed is better for now. So the patch looks OK to me. > > Looking at this some more, I would suggest changing devmap_managed_enable_get() > and devmap_managed_enable_put() to do the special case checking instead of > doing it in memremap_pages() and memunmap_pages(). > Then devmap_managed_enable_get() doesn't need to return an error if > CONFIG_DEV_PAGEMAP_OPS isn't defined. I have only compile tested the > following. > > Signed-off-by: Ralph Campbell <rcampbell@xxxxxxxxxx> > — This patch fixes the warning for me. Tested-by: Sachin Sant <sachinp@xxxxxxxxxxxxxxxxxx> -Sachin
