On Sat, Oct 17, 2020 at 9:42 AM David Gow <davidgow@xxxxxxxxxx> wrote: > Hi David, [...] > This looks good to me. Though, as you mention, writing to freed memory > might not bode well for system stability after the test runs. I don't > think that needs to be a goal for these tests, though. We generally tried to avoid this, since we run multiple tests, and if one crashes the kernel, the rest won't work. I'll fix this in v2. > One thing which we're hoping to add to KUnit soon is support for > skipping tests: once that's in place, we can use it to mark tests as > explicitly skipped if they rely on the GENERIC mode. That'll take a > little while to get upstream though, so I wouldn't want to hold this > up for it. This will indeed be useful. > Otherwise, from the KUnit side, this looks great. > > I also tested it against the GENERIC mode on x86_64 (which is all I > have set up here at the moment), and nothing obviously had broken. > So: > Tested-by: David Gow <davidgow@xxxxxxxxxx> Perfect, thank you!
