On Sun, Oct 18, 2020 at 12:13 PM John Hubbard <jhubbard@xxxxxxxxxx> wrote:
>
> >
> > Does adding an extra -I../../../../mm to that line not do the trick?
> >
>
> Yes, that works. Here's a differential patch on top of the series to change it
> over:
Guys, you're looking at the wrong thing.
Inside the *tools* subdirectory, that "../../.." thing makes sense.
You're in tools/testing/selftests/vm, and those crazy ".." paths are
ok. Ugly, but ok.
But the thing I objected to wasn't that tools directory ugliness.
Let me repeat what I found completely and utterly unacceptable, and
what you don't seem to have noticed, and what your patch didn't fix or
touch:
+++ a/mm/gup_test.c
+#include "../../../../mm/gup_test.h"
Notice what directory it is in? Notice how "../../.." etc is
COMPLETELY UNACCEPTABLE GARBAGE.
Linus
