On 08/11/2011 02:33 PM, Michal Hocko wrote:
On Thu 11-08-11 14:27:06, Raghavendra K T wrote:
On 08/11/2011 01:34 PM, Michal Hocko wrote:
On Wed 10-08-11 22:59:29, Raghavendra K T wrote:
[...]
This patch renames all mem variables to memcg in source file.
__mem_cgroup_try_charge for example uses local mem which cannot be
renamed because it already has a memcg argument (mem_cgroup **) then we
have mem_cgroup_try_charge_swapin and mem_cgroup_prepare_migration which
use mem_cgroup **ptr (I guess we shouldn't have more of them).
I think that __mem_cgroup_try_charge should use ptr pattern as well.
Other than that I think the clean up is good.
With __mem_cgroup_try_charge:
Acked-by: Michal Hocko<mhocko@xxxxxxx>
Thanks
Agreed, Let me know whether you prefer whole patch to be posted or
only the corresponding hunk.
I would go with the full (single) patch. I would also recommend to add
results of your tests into the changelog (which configurantion have been
tested and how did you test binary compatibility).
Thanks
Agreed. Thanks. To summarise, I have to get both the patches with
__mem_cgroup_try_charge changes into a single file, along with
configuration + binary compatible test in change log.
I 'll be sending v2 patch in next mail.
Regards
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>