From: Luo Jiaxing <luojiaxing@xxxxxxxxxx> Subject: fs_parse: mark fs_param_bad_value() as static We found the following warning when build kernel with W=1: fs/fs_parser.c:192:5: warning: no previous prototype for `fs_param_bad_value' [-Wmissing-prototypes] int fs_param_bad_value(struct p_log *log, struct fs_parameter *param) ^ CC drivers/usb/gadget/udc/snps_udc_core.o And no header file define a prototype for this function, so we should mark it as static. Link: https://lkml.kernel.org/r/1601293463-25763-1-git-send-email-luojiaxing@xxxxxxxxxx Signed-off-by: Luo Jiaxing <luojiaxing@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/fs_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/fs_parser.c~fs_parse-mark-fs_param_bad_value-as-static +++ a/fs/fs_parser.c @@ -189,7 +189,7 @@ out: } EXPORT_SYMBOL(fs_lookup_param); -int fs_param_bad_value(struct p_log *log, struct fs_parameter *param) +static int fs_param_bad_value(struct p_log *log, struct fs_parameter *param) { return inval_plog(log, "Bad value for '%s'", param->key); } _