Re: [PATCH] mm, oom: enable rate-limiting controls for oom dumps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue 13-10-20 11:23:39, Ricardo Cañuelo wrote:
> Hi Michal,
> 
> Thanks for reviewing the patch and for your suggestions:
> 
> On lun 12-10-2020 17:18:04, Michal Hocko wrote:
> > How does controling burst and interval solve the problem? Btw. this
> > should be a part of the changelog which should explain not only what but
> > also why the change is needed.
> > 
> > It is true that the oom report can generate a lot of output. This is
> > something that is brought up for quite some time. The largest part of
> > the output tends to be the list of tasks and this seems to be the case
> > for you as well. Is the list of tasks so important that you need to have
> > it in the log? If not you can simply disable this part of the log
> > altogether by /proc/sys/vm/oom_dump_tasks.
> 
> That could be another way to mitigate the problem, although losing some
> information. I'll try to come up with a better alternative.

Yes, but there is no way around this without losing information. You are
either losing whole reports or a very noisy part of a report. I consider
the first option to be worse because eligible tasks list is useful only
very seldom.

Another aspect of the problem is effectivelly broken rate limiting
because of the way how it is implemented. That is something worth
looking into IMHO.
-- 
Michal Hocko
SUSE Labs





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux