On 08/11/2011 01:56 PM, Michal Hocko wrote:
On Thu 11-08-11 13:46:19, Raghavendra K T wrote:
On 08/11/2011 01:23 PM, Michal Hocko wrote:
On Wed 10-08-11 22:59:17, Raghavendra K T wrote:
Hi,
This is the memcg cleanup patch for that was talked little ago to change the "struct
mem_cgroup *mem" variable to "struct mem_cgroup *memcg".
The patch is though trivial, it is huge one.
Testing : Compile tested with following configurations.
1) CONFIG_CGROUP_MEM_RES_CTLR=y CONFIG_CGROUP_MEM_RES_CTLR_SWAP=y
2) CONFIG_CGROUP_MEM_RES_CTLR=y CONFIG_CGROUP_MEM_RES_CTLR_SWAP=n
3) CONFIG_CGROUP_MEM_RES_CTLR=n CONFIG_CGROUP_MEM_RES_CTLR_SWAP=n
How exactly have you tested? Compiled and compared before/after binaries
(it shouldn't change, right)?
Yes, But idea was to ensure that both #ifdef and #else part are hit
during compilation, which could expose some corrections needed.
I am not sure I understand. You have used different combinations of
configuration to trigger all #ifdefs but that doesn't change anything on
the fact that the code should be exactly same before and after your
patch, right?
Yes you are right again. No change in the code after the patch.
It was just to exercise I have not missed any valid changes in both
paths, and it does not break compilation.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>