On Thu 08-10-20 14:56:13, Vlastimil Babka wrote: > On 10/8/20 2:23 PM, Michal Hocko wrote: > > On Thu 08-10-20 13:41:57, Vlastimil Babka wrote: > > > We initialize boot-time pagesets with setup_pageset(), which sets high and > > > batch values that effectively disable pcplists. > > > > > > We can remove this wrapper if we just set these values for all pagesets in > > > pageset_init(). Non-boot pagesets then subsequently update them to the proper > > > values. > > > > > > No functional change. > > > > > > Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx> > > > Reviewed-by: David Hildenbrand <david@xxxxxxxxxx> > > > > Acked-by: Michal Hocko <mhocko@xxxxxxxx> > > Thanks! > > > Btw. where do we initialize pcp->count? I thought that pcp allocator > > zeroes out the allocated memory but alloc_percpu is GFP_KERNEL like. > > pageset_init() does: > memset(p, 0, sizeof(*p)) Ohh, I have missed pcp is embeded into per_cpu_pageset. Using it as s pointer here confused me. Sorry about the noise. -- Michal Hocko SUSE Labs
