Re: [PATCH 6/9] mm, page_alloc: cache pageset high and batch in struct zone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/5/20 3:28 PM, Michal Hocko wrote:
On Tue 22-09-20 16:37:09, Vlastimil Babka wrote:
All per-cpu pagesets for a zone use the same high and batch values, that are
duplicated there just for performance (locality) reasons. This patch adds the
same variables also to struct zone as a shared copy.

This will be useful later for making possible to disable pcplists temporarily
by setting high value to 0, while remembering the values for restoring them
later. But we can also immediately benefit from not updating pagesets of all
possible cpus in case the newly recalculated values (after sysctl change or
memory online/offline) are actually unchanged from the previous ones.

Advantage of this patch is not really clear from it in isolation. Maybe
merge it with the patch which uses the duplicated state.

I'm not sure that would help its reviewability? As the patch that uses it is the last, largest one. And there is already a small advantage right away as changelog explains.




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux