On Mon, Oct 05, 2020 at 01:50:30PM +0200, Greg KH wrote: > On Mon, Oct 05, 2020 at 02:42:50PM +0300, Jarkko Sakkinen wrote: > > On Mon, Oct 05, 2020 at 09:45:54AM +0100, Christoph Hellwig wrote: > > > On Sat, Oct 03, 2020 at 04:39:25PM +0200, Greg KH wrote: > > > > > @@ -0,0 +1,173 @@ > > > > > +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) > > > > > > > > You use gpl-only header files in this file, so how in the world can it > > > > be bsd-3 licensed? > > > > > > > > Please get your legal department to agree with this, after you explain > > > > to them how you are mixing gpl2-only code in with this file. > > > > > > > > > +// Copyright(c) 2016-18 Intel Corporation. > > > > > > > > Dates are hard to get right :( > > > > > > As is comment formatting apparently. Don't use // comments for anything > > > but the SPDX header, please. > > > > I'll bring some context to this. > > > > When I moved into using SPDX, I took the example from places where I saw > > also the copyright using "//". That's the reason for the choice. > > > > I.e. > > > > $ git grep "// Copyright" | wc -l > > 2123 > > > > I don't care, which one to use, just wondering is it done in the wrong > > way in all these sites? > > Probably, but I know at least one subsystem requires their headers to be > in this manner. There's no accounting for taste :) This discussion is a bit confusing [*], so I'll just ask from Git: ➜ linux-sgx (master) ✔ git --no-pager grep "\/\/ Copyright" arch/x86 arch/x86/kernel/cpu/sgx/driver.c:// Copyright(c) 2016-20 Intel Corporation. arch/x86/kernel/cpu/sgx/encl.c:// Copyright(c) 2016-20 Intel Corporation. arch/x86/kernel/cpu/sgx/ioctl.c:// Copyright(c) 2016-20 Intel Corporation. arch/x86/kernel/cpu/sgx/main.c:// Copyright(c) 2016-20 Intel Corporation. OK, now I think I know what to do :-) > thanks, > > greg k-h [*] One thing I've been wondering for a long time is that, why new code should have the copyright platters in the first place? I get it for pre-Git era but now there is a cryptographic log of authority. Copyright platters, remarking the authors to the header and MODULE_AUTHOR() macro are the three things that I just do not get in the modern times. /Jarkko
