On Fri, Oct 02, 2020 at 03:26:47PM -0400, Peter Xu wrote: > Both of the mm pointers are not needed after commit 7a4830c380f3 ("mm/fork: > Pass new vma pointer into copy_page_range()"). > > Jason Gunthorpe also reported that the ordering of copy_page_range() is odd. > Since working at it, reorder the parameters to be logical, by (1) always put > the dst_* fields to be before src_* fields, and (2) keep the same type of > parameters together. > > CC: Jason Gunthorpe <jgg@xxxxxxxx> > CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Reported-by: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx> > Signed-off-by: Peter Xu <peterx@xxxxxxxxxx> Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx> -- Kirill A. Shutemov