Hi Hillf,
On Wednesday, September 30, 2020 5:27 AM, Hillf Danton <hdanton@xxxxxxxx> wrote:
> On Mon, 28 Sep 2020 11:45:13 -0500 Nabeel M Mohamed wrote:
> >
> > +/* Rate limited version of mp_pr_err(). */
> > +#define mp_pr_rl(_fmt, _err, ...) \
> > +do { \
> > + static unsigned long mp_pr_rl_state; \
>
> We do not need to declare a mp_pr_rl_state per use case of mp_pr_rl.
Agreed, will make it a global state to rate limit all messages vs. by call site.
>
> > + uint dly = msecs_to_jiffies(333); \
>
> printk_timed_ratelimit() needs msec as input instead of tick.
Nice catch, thanks!
Will address both your comments in v2.
Thanks,
Nabeel
