On 23.09.20 18:29, Mike Rapoport wrote: > From: Mike Rapoport <rppt@xxxxxxxxxxxxx> > > The early_pfn_valid() macro is defined by it is never used. > Remove it. > > Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxx> > --- > include/linux/mmzone.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 8379432f4f2f..38264363b0d4 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -1376,7 +1376,6 @@ static inline unsigned long next_present_section_nr(unsigned long section_nr) > #define pfn_to_nid(pfn) (0) > #endif > > -#define early_pfn_valid(pfn) pfn_valid(pfn) > void sparse_init(void); > #else > #define sparse_init() do {} while (0) > @@ -1396,10 +1395,6 @@ struct mminit_pfnnid_cache { > int last_nid; > }; > > -#ifndef early_pfn_valid > -#define early_pfn_valid(pfn) (1) > -#endif > - > /* > * If it is possible to have holes within a MAX_ORDER_NR_PAGES, then we > * need to check pfn validity within that MAX_ORDER_NR_PAGES block. > Think the last user was removed with commit 73a6e474cb376921a311786652782155eac2fdf0 Author: Baoquan He <bhe@xxxxxxxxxx> Date: Wed Jun 3 15:57:55 2020 -0700 mm: memmap_init: iterate over memblock regions rather that check each PFN When called during boot the memmap_init_zone() function checks if each PFN is valid and actually belongs to the node being initialized using early_pfn_valid() and early_pfn_in_nid(). Acked-by: David Hildenbrand <david@xxxxxxxxxx> -- Thanks, David / dhildenb