Re: [PATCH v10 1/3] fs: Add trusted_for(2) syscall implementation and related sysctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi "Mickaël,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on arm64/for-next/core]
[also build test WARNING on tip/x86/asm kselftest/next linus/master v5.9-rc6 next-20200924]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Micka-l-Sala-n/Add-trusted_for-2-was-O_MAYEXEC/20200924-234005
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: mips-randconfig-r024-20200923 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c32e69b2ce7abfb151a87ba363ac9e25abf7d417)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   In file included from fs//autofs/dev-ioctl.c:9:
>> include/linux/syscalls.h:432:46: warning: declaration of 'enum trusted_for_usage' will not be visible outside of this function [-Wvisibility]
   asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
                                                ^
   1 warning generated.
--
   In file included from drivers/char/random.c:335:
>> include/linux/syscalls.h:432:46: warning: declaration of 'enum trusted_for_usage' will not be visible outside of this function [-Wvisibility]
   asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
                                                ^
   drivers/char/random.c:2297:6: warning: no previous prototype for function 'add_hwgenerator_randomness' [-Wmissing-prototypes]
   void add_hwgenerator_randomness(const char *buffer, size_t count,
        ^
   drivers/char/random.c:2297:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void add_hwgenerator_randomness(const char *buffer, size_t count,
   ^
   static 
   2 warnings generated.
--
   In file included from drivers/android/binder.c:66:
>> include/linux/syscalls.h:432:46: warning: declaration of 'enum trusted_for_usage' will not be visible outside of this function [-Wvisibility]
   asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
                                                ^
   In file included from drivers/android/binder.c:6207:
   In file included from drivers/android/binder_trace.h:399:
   include/trace/define_trace.h:95:10: fatal error: './binder_trace.h' file not found
   #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/define_trace.h:90:32: note: expanded from macro 'TRACE_INCLUDE'
   # define TRACE_INCLUDE(system) __TRACE_INCLUDE(system)
                                  ^~~~~~~~~~~~~~~~~~~~~~~
   include/trace/define_trace.h:87:34: note: expanded from macro '__TRACE_INCLUDE'
   # define __TRACE_INCLUDE(system) __stringify(TRACE_INCLUDE_PATH/system.h)
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/stringify.h:10:27: note: expanded from macro '__stringify'
   #define __stringify(x...)       __stringify_1(x)
                                   ^~~~~~~~~~~~~~~~
   include/linux/stringify.h:9:29: note: expanded from macro '__stringify_1'
   #define __stringify_1(x...)     #x
                                   ^~
   <scratch space>:35:1: note: expanded from here
   "./binder_trace.h"
   ^~~~~~~~~~~~~~~~~~
   1 warning and 1 error generated.

# https://github.com/0day-ci/linux/commit/4671d1c72b214c586edd9293053dabfa053b003a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Micka-l-Sala-n/Add-trusted_for-2-was-O_MAYEXEC/20200924-234005
git checkout 4671d1c72b214c586edd9293053dabfa053b003a
vim +432 include/linux/syscalls.h

   413	
   414	/* fs/open.c */
   415	asmlinkage long sys_statfs(const char __user * path,
   416					struct statfs __user *buf);
   417	asmlinkage long sys_statfs64(const char __user *path, size_t sz,
   418					struct statfs64 __user *buf);
   419	asmlinkage long sys_fstatfs(unsigned int fd, struct statfs __user *buf);
   420	asmlinkage long sys_fstatfs64(unsigned int fd, size_t sz,
   421					struct statfs64 __user *buf);
   422	asmlinkage long sys_truncate(const char __user *path, long length);
   423	asmlinkage long sys_ftruncate(unsigned int fd, unsigned long length);
   424	#if BITS_PER_LONG == 32
   425	asmlinkage long sys_truncate64(const char __user *path, loff_t length);
   426	asmlinkage long sys_ftruncate64(unsigned int fd, loff_t length);
   427	#endif
   428	asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len);
   429	asmlinkage long sys_faccessat(int dfd, const char __user *filename, int mode);
   430	asmlinkage long sys_faccessat2(int dfd, const char __user *filename, int mode,
   431				       int flags);
 > 432	asmlinkage long sys_trusted_for(int fd, enum trusted_for_usage usage, u32 flags);
   433	asmlinkage long sys_chdir(const char __user *filename);
   434	asmlinkage long sys_fchdir(unsigned int fd);
   435	asmlinkage long sys_chroot(const char __user *filename);
   436	asmlinkage long sys_fchmod(unsigned int fd, umode_t mode);
   437	asmlinkage long sys_fchmodat(int dfd, const char __user * filename,
   438				     umode_t mode);
   439	asmlinkage long sys_fchownat(int dfd, const char __user *filename, uid_t user,
   440				     gid_t group, int flag);
   441	asmlinkage long sys_fchown(unsigned int fd, uid_t user, gid_t group);
   442	asmlinkage long sys_openat(int dfd, const char __user *filename, int flags,
   443				   umode_t mode);
   444	asmlinkage long sys_openat2(int dfd, const char __user *filename,
   445				    struct open_how *how, size_t size);
   446	asmlinkage long sys_close(unsigned int fd);
   447	asmlinkage long sys_close_range(unsigned int fd, unsigned int max_fd,
   448					unsigned int flags);
   449	asmlinkage long sys_vhangup(void);
   450	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux