Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: > On Mon, Jul 25, 2011 at 10:35:34PM +0200, Johannes Weiner wrote: >> Ever since 'ea9b990 fuse: implement perform_write', the .write_begin >> and .write_end aops have been dead code. >> >> Their task - acquiring a page from the page cache, sending out a write >> request and releasing the page again - is now done batch-wise to >> maximize the number of pages send per userspace request. > > The loop code still calls them uncondtionally. This actually is a big > as write_begin and write_end require filesystems specific locking, > and might require code in the filesystem to e.g. update the ctime > properly. I'll let Miklos chime in if leaving them in was intentional, > and if it was a comment is probably justified. Loop checks for ->write_begin() and falls back to ->write if the former isn't defined. So I think the patch is fine. I tested loop over fuse, and it still works after the patch. Added to for-next. Thanks, Miklos -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>