Re: [PATCH v12 8/8] x86: Disallow vsyscall emulation when CET is enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Yu, Yu-cheng" <yu-cheng.yu@xxxxxxxxx>, Sean Christopherson <sean.j.christopherson@xxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>
Subject: Re: [PATCH v12 8/8] x86: Disallow vsyscall emulation when CET is enabled
From: Dave Hansen <dave.hansen@xxxxxxxxx>
Date: Wed, 23 Sep 2020 15:08:42 -0700
Cc: X86 ML <x86@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, "open list:DOCUMENTATION" <linux-doc@xxxxxxxxxxxxxxx>, Linux-MM <linux-mm@xxxxxxxxx>, linux-arch <linux-arch@xxxxxxxxxxxxxxx>, Linux API <linux-api@xxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Balbir Singh <bsingharora@xxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Cyrill Gorcunov <gorcunov@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Eugene Syromiatnikov <esyr@xxxxxxxxxx>, Florian Weimer <fweimer@xxxxxxxxxx>, "H.J. Lu" <hjl.tools@xxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Mike Kravetz <mike.kravetz@xxxxxxxxxx>, Nadav Amit <nadav.amit@xxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, "Ravi V. Shankar" <ravi.v.shankar@xxxxxxxxx>, Vedvyas Shanbhogue <vedvyas.shanbhogue@xxxxxxxxx>, Dave Martin <Dave.Martin@xxxxxxx>, Weijiang Yang <weijiang.yang@xxxxxxxxx>
In-reply-to: <a2e872ef-5539-c7c1-49ca-95d590f3b92a@intel.com>
References: <20200918192312.25978-1-yu-cheng.yu@intel.com> <20200918192312.25978-9-yu-cheng.yu@intel.com> <CALCETrXfixDGJhf0yPw-OckjEdeF2SbYjWFm8VbLriiP0Krhrg@mail.gmail.com> <c96c98ec-d72a-81a3-06e2-2040f3ece33a@intel.com> <24718de58ab7bc6d7288c58d3567ad802eeb6542.camel@intel.com> <CALCETrWssUxxfhPPJZgPOmpaQcf4o9qCe1j-P7yiPyZVV+O8ZQ@mail.gmail.com> <20200923212925.GC15101@linux.intel.com> <a2e872ef-5539-c7c1-49ca-95d590f3b92a@intel.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 9/23/20 3:06 PM, Yu, Yu-cheng wrote:
> I think I'll add a check here for (r + 8) >= TASK_SIZE_MAX.  It is 
> better than getting a fault.

There's also wrmsr_safe().

Follow-Ups:
- Re: [PATCH v12 8/8] x86: Disallow vsyscall emulation when CET is enabled
  - From: Yu, Yu-cheng

References:
- [PATCH v12 0/8] Control-flow Enforcement: Indirect Branch Tracking
  - From: Yu-cheng Yu
- [PATCH v12 8/8] x86: Disallow vsyscall emulation when CET is enabled
  - From: Yu-cheng Yu
- Re: [PATCH v12 8/8] x86: Disallow vsyscall emulation when CET is enabled
  - From: Andy Lutomirski
- Re: [PATCH v12 8/8] x86: Disallow vsyscall emulation when CET is enabled
  - From: Yu, Yu-cheng
- Re: [PATCH v12 8/8] x86: Disallow vsyscall emulation when CET is enabled
  - From: Yu-cheng Yu
- Re: [PATCH v12 8/8] x86: Disallow vsyscall emulation when CET is enabled
  - From: Andy Lutomirski
- Re: [PATCH v12 8/8] x86: Disallow vsyscall emulation when CET is enabled
  - From: Sean Christopherson
- Re: [PATCH v12 8/8] x86: Disallow vsyscall emulation when CET is enabled
  - From: Yu, Yu-cheng

Prev by Date: Re: [PATCH] mmap_lock: add tracepoints around lock acquisition
Next by Date: Re: [PATCH v12 8/8] x86: Disallow vsyscall emulation when CET is enabled
Previous by thread: Re: [PATCH v12 8/8] x86: Disallow vsyscall emulation when CET is enabled
Next by thread: Re: [PATCH v12 8/8] x86: Disallow vsyscall emulation when CET is enabled
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]