On Fri, Aug 05, 2011 at 04:25:16PM +0100, Mel Gorman wrote: > The meaning of the return values of -1, 0, 1 with the caller doing > > if (err) > ... > else if (!err) > ... > > is tricky to work out. split_huge_page only needs to be called if > returning 0. Would it be possible to have the split_huge_page called in > this function? The end of the function would then look like I'm doing the cleanup but problem is to call split_huge_page in move_huge_pmd I'd need to call move_huge_pmd even when extent < HPAGE_PMD_SIZE. That's an unnecessary call... That is the reason of the tristate. Alternatively I could call split_huge_page even if move_huge_pmd returns -1 (so making it return 0) but then it'd be another unnecessary call. Not sure anymore if it's worth removing the -1. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>