Re: [PATCH 02/14] block: switch register_disk to use blkdev_get_by_dev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx>
Subject: Re: [PATCH 02/14] block: switch register_disk to use blkdev_get_by_dev
From: Christoph Hellwig <hch@xxxxxx>
Date: Sat, 19 Sep 2020 07:15:20 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Minchan Kim <minchan@xxxxxxxxxx>, Stefan Haberland <sth@xxxxxxxxxxxxx>, Jan Hoeppner <hoeppner@xxxxxxxxxxxxx>, Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Len Brown <len.brown@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, linux-ide@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-block@xxxxxxxxxxxxxxx
In-reply-to: <091931b1-eb9c-e45e-c9e8-501554618508@gmail.com>
References: <20200917165720.3285256-1-hch@lst.de> <20200917165720.3285256-3-hch@lst.de> <091931b1-eb9c-e45e-c9e8-501554618508@gmail.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Fri, Sep 18, 2020 at 11:52:39AM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 17.09.2020 19:57, Christoph Hellwig wrote:
>
>> Use blkdev_get_by_dev instead of open coding it using bdget_disk +
>> blkdev_get.
>
>    I don't see where you are removing bdget_disk() call (situated just before
> the below code?)...

Indeed.  That's what you get for a messy last minute rebase.. :(

References:
- remove blkdev_get as a public API
  - From: Christoph Hellwig
- [PATCH 02/14] block: switch register_disk to use blkdev_get_by_dev
  - From: Christoph Hellwig
- Re: [PATCH 02/14] block: switch register_disk to use blkdev_get_by_dev
  - From: Sergei Shtylyov

Prev by Date: Re: [patch 04/15] shmem: shmem_writepage() split unlikely i915 THP
Next by Date: Re: [PATCH v2 0/9] ARM: remove set_fs callers and implementation
Previous by thread: Re: [PATCH 02/14] block: switch register_disk to use blkdev_get_by_dev
Next by thread: [PATCH 01/14] block: move the NEED_PART_SCAN flag to struct gendisk
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]