Michal Hocko <mhocko@xxxxxxxx> wrote: > On Wed 16-09-20 09:19:27, Miaohe Lin wrote: >> Since commit fb2a6fc56be6 ("mm: memcg: rework and document OOM waiting >> and wakeup"), we have renamed mem_cgroup_oom_lock to >> mem_cgroup_oom_trylock. So replace mem_cgroup_oom_lock with mem_cgroup_oom_trylock in comment. > >While you are right I find the comment more confusing then helpful. >What does it try to tell us actually? Is it still valid? Shouldn't we rather remove it or make it more clear? >> It seems this comment no long make sense. Many thanks for your nice advise.