On Wed, Aug 03, 2011 at 01:06:29PM +0200, Johannes Weiner wrote: > On Wed, Aug 03, 2011 at 12:58:19PM +0200, Johannes Weiner wrote: > > On Thu, Jul 21, 2011 at 05:28:45PM +0100, Mel Gorman wrote: > > > Direct reclaim should never writeback pages. Warn if an attempt > > > is made. > > > > > > Signed-off-by: Mel Gorman <mgorman@xxxxxxx> > > > > Acked-by: Johannes Weiner <jweiner@xxxxxxxxxx> > > Oops, too fast. > > Shouldn't the WARN_ON() be at the top of the function, rather than > just warn when the write is deferred due to delalloc? I thought it made more sense to put the warning at the point where ext4 would normally ignore ->writepage. That said, in my current revision of the series, I've dropped these patches altogether as page migration should be able to trigger the same warnings but be called from paths that are of less concern for stack overflows (or at the very least be looked at as a separate series). -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>