Re: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab_node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michal Hocko writes:
On Tue 15-09-20 15:47:37, Chris Down wrote:
zangchunxin@xxxxxxxxxxxxx writes:
> +		if (signal_pending(current))
> +			return;

This doesn't match your patch title, please update it. :-)

I have to admit I have completely missed this and I think that this
should better be fatal_signal_pending because that would make sure that
the userspace will not see an incomplete operation. This is a general
practice for other bail outs as well.

Oh sorry, to be clear, I meant the patch should match the title, not the other way around.




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux