On Tue, Sep 08, 2020 at 08:36:32AM +0000, HORIGUCHI NAOYA(堀口 直也) wrote: > > Theoretically, it could happen that a error could be collapsed into a new I guess you meant page here? ^^^^ > thp just after passing over the following block: > > 1408 if (PageTransHuge(hpage)) { > 1409 if (try_to_split_thp_page(p, "Memory Failure") < 0) { > 1410 action_result(pfn, MF_MSG_UNSPLIT_THP, MF_IGNORED); > 1411 return -EBUSY; > 1412 } > 1413 VM_BUG_ON_PAGE(!page_count(p), p); > 1414 } > > So I feel that some check might be added after holding page lock to avoid > that case. Or acutally, it might better that moving the above block into > page lock is more better for simpler code. I will have a look at this. Thanks -- Oscar Salvador SUSE L3