Hi, Thank you for sending a patch. The change itself is fine to me, but you might need adjust and resubmit it in accordance with the guideline. https://www.kernel.org/doc/html/latest/process/submitting-patches.html # Signed-off-by line should be included in the patch description, # and you need send a patch in plain text mode. Thanks, Naoya Horiguchi On Wed, Sep 02, 2020 at 11:46:14AM +0000, yaoaili [么爱利] wrote: > Signed-off-by: Yao Aili< yaoaili@xxxxxxxxxxxx> > Signed-off-by: Yang Feng < yangfeng1@xxxxxxxxxxxx> > > -----邮件原件----- > 发件人: Matthew Wilcox [mailto:willy@xxxxxxxxxxxxx] > 发送时间: 2020年9月2日 19:35 > 收件人: yaoaili [么爱利] <yaoaili@xxxxxxxxxxxx> > 抄送: naoya.horiguchi@xxxxxxx; linux-mm@xxxxxxxxx; YANGFENG1 [杨峰] <YANGFENG1@xxxxxxxxxxxx> > 主题: Re: [PATCH] fix incorrect compound page flags store > > On Wed, Sep 02, 2020 at 11:24:59AM +0000, yaoaili [么爱利] wrote: > > PageHuge(p) branch will never be true,but for compound page we need to set page_flags to correct value. > Signed-off-by: Yao aili< yaoaili@xxxxxxxxxxxx> > Signed-off-by: Yang feng < yangfeng1@xxxxxxxxxxxx> > > You're missing a Signed-off-by line. > > Your analysis is correct; PageHuge was tested for a few dozen lines higher, and we ran off to a different function. > > Ad far as I understand this function, this looks right to me. > > Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> > > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c index > > f1aa6433f404..e6995976b11d 100644 > > --- a/mm/memory-failure.c > > +++ b/mm/memory-failure.c > > @@ -1382,7 +1382,7 @@ int memory_failure(unsigned long pfn, int flags) > > * page_remove_rmap() in try_to_unmap_one(). So to determine page status > > * correctly, we save a copy of the page flags at this time. > > */ > > - if (PageHuge(p)) > > + if (PageCompound(p)) > > page_flags = hpage->flags; > > else > > page_flags = p->flags; > > -- > > 2.25.1
