On Mon, Aug 24, 2020 at 02:58:11PM +0800, Li Xinhai wrote: > In has_unmovable_pages(), the page parameter would not always be the > first page within a pageblock (see how the page pointer is passed in from > start_isolate_page_range() after call __first_valid_page()), so that > would cause checking unmovable pages span two pageblocks. > > After this patch, the checking is enforced within one pageblock no matter > the page is first one or not, and obey the semantics of this function. > > This issue is found by code inspection. > > Signed-off-by: Li Xinhai <lixinhai.lxh@xxxxxxxxx> Unless I am missing something, this looks good to me. Reviewed-by: Oscar Salvador <osalvador@xxxxxxx> -- Oscar Salvador SUSE L3