Re: [PATCH v5 2/2] mm: add a field to store names for private anonymous memory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/19, Matthew Wilcox wrote:
>
> You can significantly reduce the size of this patch by doing this instead:
>
> 	union {
> 		struct {
> 			struct rb_node rb;
> 			unsigned long rb_subtree_last;
> 		} shared;
> 		const char __user *anon_name;
> 	};

Agreed,

And to me "unsigned long anon_name" looks better, vma_anon_name() should
return "unsigned long" too. The only thing which reads this string is
seq_print_vma_name() and it has typecast anon_name anyway.

But I won't insist, this is cosmetic and subjective.

Oleg.





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux