On 8/4/20 7:42 PM, Anchal Agarwal wrote: > > I think this could be done. PM_HIBERNATION_PREPARE could return -ENOTSUPP > for arm and pvh dom0 when the notifier call chain is invoked for this case > in hibernate(). This will then be an empty notifier just for checking two > usecases. > Also, for pvh dom0, the earlier code didn't register any notifier, > with this approach you are suggesting setup the notifier for hvm/pvh dom0 and > arm but fail during notifier call chain during PM_HIBERNATION_PREPARE ? Right. (Although the earlier code did register the notifier: xen_setup_pm_notifier() would return an error for !xen_hvm_domain() and PVH *is* an HVM domain, so registration would actually happen) > > I think still getting rid of suspend mode that was earlier a part of this > notifier is a good idea as it seems redundant as you pointed out earlier. Yes. -boris
