在 2020/8/4 上午6:45, Alexander Duyck 写道: > Just to correct a typo, I meant patch 17, not 18. in the comment below. > > > On Mon, Aug 3, 2020 at 3:42 PM Alexander Duyck > <alexander.duyck@xxxxxxxxx> wrote: >> >> On Sat, Jul 25, 2020 at 6:00 AM Alex Shi <alex.shi@xxxxxxxxxxxxxxxxx> wrote: >>> >>> Now pgdat.lru_lock was replaced by lruvec lock. It's not used anymore. >>> >>> Signed-off-by: Alex Shi <alex.shi@xxxxxxxxxxxxxxxxx> >>> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >>> Cc: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxxxxxx> >>> Cc: Hugh Dickins <hughd@xxxxxxxxxx> >>> Cc: Johannes Weiner <hannes@xxxxxxxxxxx> >>> Cc: linux-mm@xxxxxxxxx >>> Cc: linux-kernel@xxxxxxxxxxxxxxx >>> Cc: cgroups@xxxxxxxxxxxxxxx >> >> I really think this would be better just squashed into patch 18 >> instead of as a standalone patch since you were moving all of the >> locking anyway so it would be more likely to trigger build errors if >> somebody didn't move a lock somewhere that was referencing this. Thanks for comments! If someone changed the lru_lock between patch 17 and this, it would cause more troubles then build error here. :) so don't warries for that. But on the other side, I am so insist to have a ceremony to remove this lock... >> >> That said this change is harmless at this point. >> >> Reviewed-by: Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx> Thanks a lot for review!
