Re: [PATCH RFC V2 17/17] x86/entry: Preserve PKRS MSR across exceptions

[Thomas Gleixner <tglx@xxxxxxxxxxxxx>]

Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:
> static __always_inline idtentry_state_t idtentry_nmi_enter(void)
> {
>      	idtentry_state_t state = {};
>
>         nmi_enter();
>         instrumentation_begin();
>         state.key = save_and_clear_key();
>         instrumentation_end();

Clearly lacks a

        return state;

But I assume you already spotted it. Otherwise the compiler would have :)

Thanks,

        tglx