On Tue, 12 Jul 2011 15:08:58 -0700 (PDT) Hugh Dickins <hughd@xxxxxxxxxx> wrote: > > All the crap^Wnice changes made to filemap.c really need some comments, > > please. Particularly when they're keyed off the bland-sounding > > "radix_tree_exception()". Apparently they have something to do with > > swap, but how is the poor reader to know this? > > The naming was intentionally bland, because other filesystems might > in future have other uses for such exceptional entries. > > (I think the field size would generally defeat it, but you can, > for example, imagine a small filesystem wanting to save sector number > there when a page is evicted.) > > But let's go bland when it's more familiar, and such uses materialize - > particularly since I only placed those checks in places where they're > needed now for shmem/tmpfs/swap. > > I'll keep the bland naming, if that's okay, but send a patch adding > a line of comment in such places. Mentioning shmem, tmpfs, swap. A better fix would be to create a nicely-documented filemap-specific function with a non-bland name which simply wraps radix_tree_exception(). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>