On 07/20/20 at 03:32pm, Mike Kravetz wrote: > On 7/19/20 11:26 PM, Baoquan He wrote: > > The local variable is for global reservation of region. > > > > Signed-off-by: Baoquan He <bhe@xxxxxxxxxx> > > --- > > mm/hugetlb.c | 24 ++++++++++++------------ > > 1 file changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index f24acb3af741..191a585bb315 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -3649,7 +3649,7 @@ static void hugetlb_vm_op_close(struct vm_area_struct *vma) > > struct resv_map *resv = vma_resv_map(vma); > > struct hugepage_subpool *spool = subpool_vma(vma); > > unsigned long reserve, start, end; > > - long gbl_reserve; > > + long glb_reserve; > > I see both 'gbl' and 'glb' being used for global in variable names. grep will > actually return more hits for gbl than glb. Unless there is consensus that > 'glb' should be used for global, I would prefer not to make this change. Ah, I thought it's typo, so it's just another kind of abbreviation. Then I am fine to drop this patch. Thanks a lot for careful reviewing on this patchset. Thanks Baoquan
