On Wed, Jul 13, 2011 at 01:48:10AM +0800, Nai Xia wrote: > I think in this case we should copy the page instead of going to unlock. > > And I think reuse_swap_page() has checked the PageKsm(page) inside and > in this case it will go to the copy path already? yes this is why it's unnecessary, I've been a bit in a paranoid mode on this code lately, one more check wouldn't have hurted but it's definitely unnecessary so please ignore... -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>