On 7/16/20 10:02 PM, Anshuman Khandual wrote: > > > On 07/16/2020 11:55 PM, Mike Kravetz wrote: >> >From 17c8f37afbf42fe7412e6eebb3619c6e0b7e1c3c Mon Sep 17 00:00:00 2001 >> From: Mike Kravetz <mike.kravetz@xxxxxxxxxx> >> Date: Tue, 14 Jul 2020 15:54:46 -0700 >> Subject: [PATCH] hugetlb: move cma reservation to code setting up gigantic >> hstate >> >> Instead of calling hugetlb_cma_reserve() directly from arch specific >> code, call from hugetlb_add_hstate when adding a gigantic hstate. >> hugetlb_add_hstate is either called from arch specific huge page setup, >> or as the result of hugetlb command line processing. In either case, >> this is late enough in the init process that all numa memory information >> should be initialized. And, it is early enough to still use early >> memory allocator. > > This assumes that hugetlb_add_hstate() is called from the arch code at > the right point in time for the generic HugeTLB to do the required CMA > reservation which is not ideal. I guess it must have been a reason why > CMA reservation should always called by the platform code which knows > the boot sequence timing better. Actually, the code does not make the assumption that hugetlb_add_hstate is called from arch specific huge page setup. It can even be called later at the time of hugetlb command line processing. My 'reasoning' is that gigantic pages can currently be preallocated from bootmem/memblock_alloc at the time of command line processing. Therefore, we should be able to reserve bootmem for CMA at the same time. Is there something wrong with this reasoning? I tested this on x86 by removing the call to hugetlb_add_hstate from arch specific code and instead forced the call at command line processing time. The ability to reserve CMA was the same. Yes, the CMA reservation interface says it should be called from arch specific code. However, if we currently depend on the ability to do memblock_alloc at hugetlb command line processing time for gigantic page preallocation, then I think we can do the CMA reservation here as well. Thinking about it some more, I suppose there could be some arch code that could call hugetlb_add_hstate too early in the boot process. But, I do not think we have an issue with calling it too late. -- Mike Kravetz
