On Tue 14-07-20 21:47:06, Tetsuo Handa wrote:
> On 2020/07/14 21:37, Michal Hocko wrote:
> > - if (mutex_lock_killable(&oom_lock))
> > + if (!mutex_trylock(&oom_lock))
> > return true;
>
> I don't like this change. The trylock needlessly wastes CPU time which could
> have been utilized by the OOM killer/reaper for reclaiming memory.
Ohh, that was an unintended hunk which stayed there from the previous
discussion. With the margin check the lock itself can stay.
>
> Rather, I want to change
>
> - if (!mutex_trylock(&oom_lock)) {
> + if (mutex_lock_killable(&oom_lock)) {
>
> in __alloc_pages_may_oom() side.
Please do not start a tangent discussion again. If you want to make this
change then post a patch with a justification.
--
Michal Hocko
SUSE Labs
