On Fri, Jul 10, 2020 at 09:14:10AM +0800, Wei Yang wrote: > On Thu, Jul 09, 2020 at 10:38:58PM +0300, Dmitry Osipenko wrote: > >08.07.2020 12:50, Wei Yang пишет: > >> move_page_tables() tries to move page table by PMD or PTE. > >> > >> The root reason is if it tries to move PMD, both old and new range should be > >> PMD aligned. But current code calculate old range and new range separately. > >> This leads to some redundant check and calculation. > >> > >> This cleanup tries to consolidate the range check in one place to reduce some > >> extra range handling. > >> > >> v4: > >> * remove a redundant parentheses pointed by Kirill > >> > >> v3: > >> * merge patch 1 with 2 as suggested by Kirill > > > >> * add patch 4 to simplify the logic to calculate next and extent > > > >Hello, Wei! > > > >Unfortunately you re-introduced the offending change that was fixed in > >v2 and today's next-20200709 on ARM32 is broken once again: > > > >BUG: Bad rss-counter state mm:db85ec46 type:MM_ANONPAGES val:190 > > > > Ah, my bad, I forget the error we met last time. It is the different format of > pmd_addr_end. > > Sorry for that. > > @ Kirill > > If you agree, I would leave the extent/next calculation as it is in patch 3. Okay. -- Kirill A. Shutemov
