On Thu 09-07-20 15:41:11, Yafang Shao wrote: > On Thu, Jul 9, 2020 at 2:26 PM Michal Hocko <mhocko@xxxxxxxxxx> wrote: > > > > From: Michal Hocko <mhocko@xxxxxxxx> > > > > The exported value includes oom_score_adj so the range is no [0, 1000] > > as described in the previous section but rather [0, 2000]. Mention that > > fact explicitly. > > > > Signed-off-by: Michal Hocko <mhocko@xxxxxxxx> > > --- > > Documentation/filesystems/proc.rst | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst > > index 8e3b5dffcfa8..78a0dec323a3 100644 > > --- a/Documentation/filesystems/proc.rst > > +++ b/Documentation/filesystems/proc.rst > > @@ -1673,6 +1673,9 @@ requires CAP_SYS_RESOURCE. > > 3.2 /proc/<pid>/oom_score - Display current oom-killer score > > ------------------------------------------------------------- > > > > +Please note that the exported value includes oom_score_adj so it is effectively > > +in range [0,2000]. > > + > > [0, 2000] may be not a proper range, see my reply in another thread.[1] > As this value hasn't been documented before and nobody notices that, I > think there might be no user really care about it before. > So we should discuss the proper range if we really think the user will > care about this value. Even if we decide the range should change, I do not really assume this will happen, it is good to have the existing behavior clarified. -- Michal Hocko SUSE Labs
