在 2020/7/6 下午7:35, Matthew Wilcox 写道: >> Would you like to give some comments or share your concern of this patchset, >> specialy for THP part? > I don't have the brain space to understand this patch set fully at > the moment. I'll note that the realtime folks are doing their best to > stamp out users of local_irq_disable(), so they won't be pleased to see > you adding a new one. Also, you removed the comment explaining why the > lock needed to be taken. > Hi Matthew, Thanks for response! As to the local_irq_disable(), we could use local_irq_save(), but Hugh Dickin suggest it's not necessary here. Also there are still much local_irq_disable() in code. Hope it would be a big trouble for only one extra. yes, The lru_lock comments is a bit early to remove, that should do in next TestClearPageLRU part. but since it would be changed soon. It won't be a critical thing. Anyway I can change it to back in next version. Thanks Alex
