Re: [RESEND Patch v2 1/4] mm/mremap: format the check in move_normal_pmd() same as move_huge_pmd()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Wei Yang <richard.weiyang@xxxxxxxxxxxxxxxxx>
Subject: Re: [RESEND Patch v2 1/4] mm/mremap: format the check in move_normal_pmd() same as move_huge_pmd()
From: "Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx>
Date: Mon, 6 Jul 2020 13:06:25 +0300
Cc: akpm@xxxxxxxxxxxxxxxxxxxx, kirill.shutemov@xxxxxxxxxxxxxxx, yang.shi@xxxxxxxxxxxxxxxxx, vbabka@xxxxxxx, willy@xxxxxxxxxxxxx, thomas_os@xxxxxxxxxxxx, thellstrom@xxxxxxxxxx, anshuman.khandual@xxxxxxx, sean.j.christopherson@xxxxxxxxx, aneesh.kumar@xxxxxxxxxxxxx, peterx@xxxxxxxxxx, walken@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, digetx@xxxxxxxxx
In-reply-to: <20200626135216.24314-2-richard.weiyang@linux.alibaba.com>
References: <20200626135216.24314-1-richard.weiyang@linux.alibaba.com> <20200626135216.24314-2-richard.weiyang@linux.alibaba.com>

On Fri, Jun 26, 2020 at 09:52:13PM +0800, Wei Yang wrote:
> No functional change, just improve the readability and prepare for
> following cleanup.

It's pretty much redundant. It doesn't provide any meaningful
readability improvement. Please drop the patch.

-- 
 Kirill A. Shutemov

References:
- [RESEND Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little
  - From: Wei Yang
- [RESEND Patch v2 1/4] mm/mremap: format the check in move_normal_pmd() same as move_huge_pmd()
  - From: Wei Yang

Prev by Date: Re: [PATCH v12 00/31] Speculative page faults
Next by Date: Re: [RESEND Patch v2 3/4] mm/mremap: calculate extent in one place
Previous by thread: [RESEND Patch v2 1/4] mm/mremap: format the check in move_normal_pmd() same as move_huge_pmd()
Next by thread: Re: [RESEND Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]