On Fri, Jul 03, 2020 at 07:52:02AM -0700, trix@xxxxxxxxxx wrote: > From: Tom Rix <trix@xxxxxxxxxx> > > clang static analysis reports a garbage return > > In file included from mm/memory.c:84: > mm/memory.c:1612:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] > return err; > ^~~~~~~~~~ > > The setting of err depends on a loop executing. > So initialize err. I'd argue that returning zero is wrong. If someone's asked to insert zero pages, that's a nonsense thing to do so it should return -EINVAL..
