On Thu, Jul 02, 2020 at 03:27:59PM +0000, Long Li wrote: > --- > changes in V4: > -Change the check function name to kmalloc_check_flags() > -Put the flags check into the kmalloc_check_flags() The point of not doing that was that this is unlikely(). With your change there is now a function call to check something that's (extremely) unlikely(). I take David's point that I misnamed the function. maybe kmalloc_fix_flags()?