2020년 7월 1일 (수) 오전 2:27, Vlastimil Babka <vbabka@xxxxxxx>님이 작성: > > On 6/17/20 7:26 AM, js1304@xxxxxxxxx wrote: > > From: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> > > > > Current implementation of LRU management for anonymous page has some > > problems. Most important one is that it doesn't protect the workingset, > > that is, pages on the active LRU list. Although, this problem will be > > fixed in the following patchset, the preparation is required and > > this patch does it. > > > > What following patchset does is to restore workingset protection. In this > > "Restore" sounds as if the protection used to be there and then it was removed. > If it's the case, it should be said what commit did that. Otherwise I would say > "implement", not "restore"? > > > case, newly created or swap-in pages are started their lifetime on the > > I would rephrase it: "After the following patch, newly created or swap-in pages > will start their lifetime... " > > > inactive list. If inactive list is too small, there is not enough chance > > to be referenced and the page cannot become the workingset. > > > > In order to provide enough chance to the newly anonymous pages, this patch > > "In order to provide the newly anonymous pages enough chance to be referenced > again..." > > > makes active/inactive LRU ratio as 1:1. > > Here I would add: > > This is just a temporary measure. Later patch in the series introduces > workingset detection for anonymous LRU that will be used to better decide if > pages should start on the active and inactive list. Afterwards this patch is > effectively reverted. > > > Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> > > Acked-by: Vlastimil Babka <vbabka@xxxxxxx> Thanks! I will change the commit description as you suggested. Thanks.
