On Wed, Jun 24, 2020 at 03:01:22PM +0000, nao.horiguchi@xxxxxxxxx wrote: > I rebased soft-offline rework patchset [1][2] onto the latest mmotm. The > rebasing required some non-trivial changes to adjust, but mainly that was > straightforward. I confirmed that the reported problem doesn't reproduce on > compaction after soft offline. For more precise description of the problem > and the motivation of this patchset, please see [2]. > > I think that the following two patches in v2 are better to be done with > separate work of hard-offline rework, so it's not included in this series. > > - mm,hwpoison: Take pages off the buddy when hard-offlining > - mm/hwpoison-inject: Rip off duplicated checks > > These two are not directly related to the reported problem, so they seems > not urgent. And the first one breaks num_poisoned_pages counting in some > testcases, and The second patch needs more consideration about commented point. > > Any comment/suggestion/help would be appreciated. Even after applied the compling fix, https://lore.kernel.org/linux-mm/20200628065409.GA546944@u2004/ madvise(MADV_SOFT_OFFLINE) will fail with EIO with hugetlb where it would succeed without this series. Steps: # git clone https://github.com/cailca/linux-mm # cd linux-mm; make # ./random 1 (Need at least two NUMA memory nodes) start: migrate_huge_offline - use NUMA nodes 0,4. - mmap and free 8388608 bytes hugepages on node 0 - mmap and free 8388608 bytes hugepages on node 4 madvise: Input/output error (x86.config is also included there.) [10718.158548][T13039] __get_any_page: 0x1d1600 free huge page [10718.165684][T13039] Soft offlining pfn 0x1d1600 at process virtual address 0x7f1dd2000000 [10718.175061][T13039] Soft offlining pfn 0x154c00 at process virtual address 0x7f1dd2200000 [10718.185492][T13039] Soft offlining pfn 0x137c00 at process virtual address 0x7f1dd2000000 [10718.195209][T13039] Soft offlining pfn 0x4c7a00 at process virtual address 0x7f1dd2200000 [10718.203483][T13039] soft offline: 0x4c7a00: hugepage isolation failed: 0, page count 2, type bfffc00001000f (locked|referenced|uptodate|dirty|head) [10718.218228][T13039] Soft offlining pfn 0x4c7a00 at process virtual address 0x7f1dd2000000 [10718.227522][T13039] Soft offlining pfn 0x2da800 at process virtual address 0x7f1dd2200000 [10718.238503][T13039] Soft offlining pfn 0x1de200 at process virtual address 0x7f1dd2000000 [10718.247822][T13039] Soft offlining pfn 0x155c00 at process virtual address 0x7f1dd2200000 [10718.259031][T13039] Soft offlining pfn 0x203600 at process virtual address 0x7f1dd2000000 [10718.268504][T13039] Soft offlining pfn 0x417600 at process virtual address 0x7f1dd2200000 [10718.278830][T13039] Soft offlining pfn 0x20a600 at process virtual address 0x7f1dd2000000 [10718.288133][T13039] Soft offlining pfn 0x1d0800 at process virtual address 0x7f1dd2200000 [10718.299198][T13039] Soft offlining pfn 0x3e5800 at process virtual address 0x7f1dd2000000 [10718.308593][T13039] Soft offlining pfn 0x21f200 at process virtual address 0x7f1dd2200000 [10718.319725][T13039] Soft offlining pfn 0x18c600 at process virtual address 0x7f1dd2000000 [10718.329301][T13039] Soft offlining pfn 0x396a00 at process virtual address 0x7f1dd2200000 [10718.378882][T13039] Soft offlining pfn 0x4d5000 at process virtual address 0x7f1dd2000000 [10718.388415][T13039] Soft offlining pfn 0x4e5000 at process virtual address 0x7f1dd2200000 [10718.398807][T13039] Soft offlining pfn 0x2f5000 at process virtual address 0x7f1dd2000000 [10718.408236][T13039] Soft offlining pfn 0x50b400 at process virtual address 0x7f1dd2200000 [10718.419781][T13039] Soft offlining pfn 0x396800 at process virtual address 0x7f1dd2000000 [10718.429677][T13039] Soft offlining pfn 0xd69c00 at process virtual address 0x7f1dd2200000 [10718.440435][T13039] Soft offlining pfn 0x21f000 at process virtual address 0x7f1dd2000000 [10718.450341][T13039] Soft offlining pfn 0x399400 at process virtual address 0x7f1dd2200000 [10718.458768][T13039] __get_any_page: 0x399400: unknown zero refcount page type bfffc000000000 The main part is, https://github.com/cailca/linux-mm/blob/master/random.c#L372 > > [1] v1: https://lore.kernel.org/linux-mm/1541746035-13408-1-git-send-email-n-horiguchi@xxxxxxxxxxxxx/ > [2] v2: https://lore.kernel.org/linux-mm/20191017142123.24245-1-osalvador@xxxxxxx/ > > Thanks, > Naoya Horiguchi > --- > Summary: > > Naoya Horiguchi (7): > mm,hwpoison: cleanup unused PageHuge() check > mm, hwpoison: remove recalculating hpage > mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED > mm,hwpoison-inject: don't pin for hwpoison_filter > mm,hwpoison: remove MF_COUNT_INCREASED > mm,hwpoison: remove flag argument from soft offline functions > mm,hwpoison: introduce MF_MSG_UNSPLIT_THP > > Oscar Salvador (8): > mm,madvise: Refactor madvise_inject_error > mm,hwpoison: Un-export get_hwpoison_page and make it static > mm,hwpoison: Kill put_hwpoison_page > mm,hwpoison: Unify THP handling for hard and soft offline > mm,hwpoison: Rework soft offline for free pages > mm,hwpoison: Rework soft offline for in-use pages > mm,hwpoison: Refactor soft_offline_huge_page and __soft_offline_page > mm,hwpoison: Return 0 if the page is already poisoned in soft-offline > > drivers/base/memory.c | 2 +- > include/linux/mm.h | 12 +- > include/linux/page-flags.h | 6 +- > include/ras/ras_event.h | 3 + > mm/hwpoison-inject.c | 18 +-- > mm/madvise.c | 39 +++--- > mm/memory-failure.c | 331 ++++++++++++++++++++------------------------- > mm/migrate.c | 11 +- > mm/page_alloc.c | 63 +++++++-- > 9 files changed, 233 insertions(+), 252 deletions(-) >
