On Sat, 2011-07-02 at 12:23 +0200, Ingo Molnar wrote: > It's certainly not a hard rule - but note that the file in question > (arch/powerpc/platforms/pseries/hotplug-memory.c) has a rather > inconsistent comment style, sometimes even within the same function: > > /* > * Remove htab bolted mappings for this section of memory > */ > ... > > /* Ensure all vmalloc mappings are flushed in case they also > * hit that section of memory > */ > > That kind of inconsistency within the same .c file and within the > same function is not defensible with a "style is a matter of taste" > argument. Right, that's a matter of different people with different taste mucking around with the same file I suppose. Most of this probably predates my involvement as a maintainer but even if not (and I really can't be bothered digging into the history), it might very well be something I didn't pay attention to while reviewing. Seriously, it's so low on the scale of what matters ... I'm sure we both have more valuable stuff to spend our time and energy on :-) Cheers, Ben. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>